Skip to content

chore: add linting for package publication#10764

Merged
tlabaj merged 1 commit into
patternfly:v6from
jonkoops:package-lint
Aug 22, 2024
Merged

chore: add linting for package publication#10764
tlabaj merged 1 commit into
patternfly:v6from
jonkoops:package-lint

Conversation

@jonkoops

@jonkoops jonkoops commented Jul 17, 2024

Copy link
Copy Markdown
Contributor

Adds a linting task called lint:publication which integrates publint so that it is ran on every package in the workspace that is published to NPM. This allows common errors to be caught, especially in relation to publishing dependencies that have mixed CommonJS and ES modules.

@patternfly-build

patternfly-build commented Jul 17, 2024 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Preview: https://patternfly-react-pr-10764.surge.sh

A11y report: https://patternfly-react-pr-10764-a11y.surge.sh

@tlabaj tlabaj requested review from dlabaj and nicolethoen July 17, 2024 15:01
@tlabaj tlabaj requested review from kmcfaul and tlabaj July 17, 2024 15:02
@jonkoops

jonkoops commented Jul 18, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Note that I haven't added this script to run on CI, as it currently fails. There are several issues in the packages that will need to be resolved before this can be enabled.

@nicolethoen

nicolethoen commented Aug 2, 2024

Copy link
Copy Markdown
Contributor

Note that I haven't added this script to run on CI, as it currently fails. There are several issues in the packages that will need to be resolved before this can be enabled.

Is there a way we can document those issues? in a follow up issue maybe?

@jonkoops

jonkoops commented Aug 2, 2024

Copy link
Copy Markdown
Contributor Author

Is there a way we can document those issues? in a follow up issue maybe?

That would work, I can log some follow up tasks with a tracker if you like.

@jonkoops

jonkoops commented Aug 2, 2024

Copy link
Copy Markdown
Contributor Author

I'll mark this one as ready to review, and log some follow up issues.

@jonkoops jonkoops marked this pull request as ready for review August 2, 2024 16:46
This was referenced Aug 3, 2024
Open
Open
Open
@jonkoops
chore: add linting for package publication
d8bc322 
Signed-off-by: Jon Koops <jonkoops@gmail.com>
@jonkoops jonkoops changed the base branch from main to v6 August 22, 2024 09:28
@jonkoops

jonkoops commented Aug 22, 2024

Copy link
Copy Markdown
Contributor Author

Since main is now in freeze I went ahead and re-directed this PR to the v6 branch.

@tlabaj tlabaj merged commit 2e6837e into patternfly:v6 Aug 22, 2024
@jonkoops jonkoops deleted the package-lint branch August 23, 2024 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nicolethoen nicolethoen nicolethoen approved these changes

@tlabaj tlabaj tlabaj approved these changes

@dlabaj dlabaj Awaiting requested review from dlabaj

@kmcfaul kmcfaul Awaiting requested review from kmcfaul

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@jonkoops @patternfly-build @nicolethoen @tlabaj @wise-king-sullyman